[PHP] File Size

[lucid]

This doesn't make any fucking sense. So I have this human readable filesize function:

Code: (php) [Select]

function read_size($bytes, $file)
{
    $kB = 1024;
    $MB = $kB * 1024;
    $GB = $MB * 1024;
    $TB = $GB * 1024;
   
    if(!is_file($file))
    {
        return "Directory";
    }
    elseif(is_file($file))
    {
        switch($bytes)
        {
            case $bytes < $kB:
                return $bytes . ' B';
                break;
            case $bytes >= $kB && $bytes < $MB:
                return round($bytes / $kB, 2) . ' KB';
                break;
            case $bytes >= $MB && $bytes < $GB:
                return round($bytes / $MB, 2) . ' MB';
                break;
            case $bytes >= $GB && $bytes < $TB:
                return round($bytes / $GB, 2) . ' GB';
                break;
            case $bytes >= $TB:
                return round($bytes / $TB, 2) . ' TB';
                break;
        }
    }
}

Also just to be thorough, here's where I call the function:

Code: [Select]

                <tr>
                    <td><?php echo $file; ?></td>
                    <td><?php echo read_size(filesize($path_and_file), $file); ?></td>
                    <td><?php echo view_perms($file); ?></td>

And at first glance it seems to work fine. It works just fine in the directory that it shows the contents of by default. However, when I back out to any other directory it says that everything is a directory. I just created a .txt file and in the filesize area it just said Directory instead of showing the filesize. I don't think that makes any fucking sense can you guys see a problem in my function?

[ande]

There is nothing wrong. My best guess is that you are passing wrong file path values. If you send a path that does not exist, it will return Directory.

[lucid]

Well, here's what the file manager looks like in the default directory



And here's what it looks like when I go back a directory



Hopefully that makes it clearer. I'm not sure what you mean by me sending a path that doesn't exist

[ca0s]

Maybe
<?php echo read_size(filesize($path_and_file), $path_and_file); ?>
?
ande's right, you're probably passing that function a wrong path+file.

Btw, any special reason for doing this:

Code: (php) [Select]

    if(!is_file($file))
    {
    }
    elseif(is_file($file))
Instead of just

Code: (php) [Select]

    if(!is_file($file))
    {
    }
    else {
    }
?

[lucid]

Well that was simpler than I imagined. You guys were right. All I did was change $file to $path_and_file and it works now. Thanks ande and ca0s.